Mark models/fixtures as generated
#24775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
skip-changelog
pull-request-size
bot
added
the
size/XS
techknowlogick
approved these changes
May 17, 2023
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
May 17, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
I suggest not doing this ..... #24782 They are not generated. And we should keep an eye on these files when reviewing. |
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
May 18, 2023
This reverts commit 71451ab.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 18, 2023
* giteaofficial/main: Enable two vue eslint rules (go-gitea#24780) Add two eslint plugins (go-gitea#24776) Mark `models/fixtures` as generated (go-gitea#24775) Fix TestMinioStorageIterator skip message (go-gitea#24765) Fix missed table name on iterate lfs meta objects (go-gitea#24768) Revert "Fix missed table name on iterate lfs meta objects" (go-gitea#24764) Make the color of zero-contribution-squares in the activity heatmap more subtle (go-gitea#24758) Fix missed table name on iterate lfs meta objects Skip TestMinioStorageIterator on CI (go-gitea#24762) Support no label/assignee filter and batch clearing labels/assignees (go-gitea#24707) Support for status check pattern (go-gitea#24633) Updates to doc (go-gitea#24757) Ignore build for docs only (go-gitea#24761) Fix team members API endpoint pagination (go-gitea#24754) Make mailer SMTP check have timed context (go-gitea#24751) Add @garymoon to MAINTAINERS (go-gitea#24752) Skip TestRepoCommitsStatusParallel on CI (go-gitea#24741) Respect original content when creating secrets (go-gitea#24745)
silverwind
pushed a commit
that referenced
this pull request
May 18, 2023
They are not generated in some cases (although they can). And we should keep an eye on these files when reviewing. When reviewing, files can be marked as "Viewed" and then it is collapsed.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 19, 2023
* giteaofficial/main: replace `drone exec` to `act_runner exec` in test README.md (go-gitea#24791) Fix OAuth loading state (go-gitea#24788) Remove duplicated issues options and some more refactors (go-gitea#24787) Revert "Mark `models/fixtures` as generated (go-gitea#24775)" (go-gitea#24782) Remove background on user dashboard filter bar (go-gitea#24779)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes diffs like https://github.com/go-gitea/gitea/pull/24676/files more readable. I'm not sure if those are actually generated, but they are good to collapse in diffs anyways.